Resolve #957
Open
Resolve #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliasymak24
suggested changes
Aug 23, 2024
app/main.py
Outdated
There was a problem hiding this comment.
No need to commit anything to this file
app/cinema.sqlite
Outdated
| self.connection.execute( | ||
| f""" | ||
| INSERT INTO {self.table_name} (first_name, last_name) | ||
| VALUES (?, ?) |
There was a problem hiding this comment.
Use parametrization, as here you are sure which fileds you insert
There was a problem hiding this comment.
You didn't change this
first_name = ?, last_name = ?
app/managers.py
Outdated
| ) | ||
| self.connection.commit() | ||
|
|
||
| def all(self) -> list: |
There was a problem hiding this comment.
This function will return list of what? Fix annotation
app/managers.py
Outdated
Comment on lines
29
to
30
| Actor(*actor) | ||
| for actor in all_actors |
app/managers.py
Outdated
| SET first_name = ?, last_name = ? | ||
| WHERE id = ? | ||
| """, | ||
| (id_, new_first_name, new_last_name), |
oliasymak24
suggested changes
Aug 23, 2024
| self.connection.execute( | ||
| f""" | ||
| INSERT INTO {self.table_name} (first_name, last_name) | ||
| VALUES (?, ?) |
There was a problem hiding this comment.
You didn't change this
first_name = ?, last_name = ?
app/managers.py
Outdated
|
|
||
| class ActorManager: | ||
| def __init__(self) -> None: | ||
| self.connection = sqlite3.connect("../cinema.sqlite") |
oliasymak24
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.